gpuOwL: an OpenCL program for Mersenne primality testing

[preda]

Originally Posted by kriesel

I've never used git; I always download a zipfile [...]

Ken, I updated the Makefile with the target gpuowl-win (changed the executable name accordingly, you'll get gpuowl-win, you need to rename it if the name is not good), added the strip too for the windows target.

If you don't have git, you need to put something manually in version.inc, changing this line:
echo "`git describe --long --dirty --always`" > version.inc
to something like:
echo "v6.5-8-g005297a" > version.inc

If you're building the version string manually, don't worry about the middle number, just replace it with 'x' such: v6.5-x-g005297a

The convention now is, if there are uncommited changes (local changes to the source), to suffix with -dirty: v6.5-x-g005297a-dirty , do indicate it's not exactly equal to that commit. (But for a public build it would be nice to be not-dirty, of course.)

You may try to install git, it may make the workflow a bit easier. After the initial "git clone" you'll only need "git pull" to get the delta.

[preda]

Originally Posted by SELROC

I don't know what it means, it seems that a string is missing,


echo "git describe --long --dirty" > version.inc
fatal: No names found, cannot describe anything.
echo Version: cat version.inc
Version: ""

Thanks! I didn't realize that the tag is not pushed by default to remote on "git push", fixed now. If you retry, the version should be properly set now. Also added a check which rejects an empty VERSION on compilation, to prevent non-intentional build without version.

So, "git describe" searches for a git tag where it takes the version string from (e.g. "v6.5"), and it didn't like that there was no tag at all, because I forgot to push the tag to remote.

Originally Posted by preda

Thanks! I didn't realize that the tag is not pushed by default to remote on "git push", fixed now. If you retry, the version should be properly set now. Also added a check which rejects an empty VERSION on compilation, to prevent non-intentional build without version.

So, "git describe" searches for a git tag where it takes the version string from (e.g. "v6.5"), and it didn't like that there was no tag at all, because I forgot to push the tag to remote.

It has a git tag now, however it is not a version like x.y

[M344587487]

Originally Posted by SELROC

It has a git tag now, however it is not a version like x.y

It's just the commit hash which is all that's in version.inc. I'm prepending "6.5-x-" for now.

Originally Posted by kriesel

Would need to first install git, yes? in the msys/mingw environment that's atop Windows 7, where the compiling gets done, I think. It looks like it's already there in msys2/mingw.

This gives 5 ways on windows, some oriented to Win 10.
https://www.jamessturtevant.com/post...it-on-Windows/

If you already have it in mingw try that, otherwise I'd try the commandline bit of git for windows from your link.

Originally Posted by M344587487

It's just the commit hash which is all that's in version.inc. I'm prepending "6.5-x-" for now.

The commit hash is a precise way to specify a version, probably we need no more information for the purpose.

[preda]

Originally Posted by SELROC

It has a git tag now, however it is not a version like x.y

What do you mean, what is it like?

The version is supposed to look something like this:
v6.5-8-g005297a or v6.5-8-g005297a-dirty

Which gives at the same time a logical idea of the version (6.5), and access to the commit.

[preda]

Originally Posted by M344587487

It's just the commit hash which is all that's in version.inc. I'm prepending "6.5-x-" for now.

It might have just the hash because you didn't pull the git tag ("v6.5") yet. Probably after the next git pull this will be solved.

Originally Posted by preda

What do you mean, what is it like?

The version is supposed to look something like this:
v6.5-8-g005297a or v6.5-8-g005297a-dirty

Which gives at the same time a logical idea of the version (6.5), and access to the commit.

https://github.com/preda/gpuowl/issues/43

[M344587487]

Originally Posted by SELROC

The commit hash is a precise way to specify a version, probably we need no more information for the purpose.

It is but not human-readable. The format preda is using is x.y-z-hash, might as well follow convention.

Originally Posted by preda

It might have just the hash because you didn't pull the git tag ("v6.5") yet. Probably after the next git pull this will be solved.

That did it. I was on the latest commit and either pulled before you added the tag or "git pull origin master" doesn't get the tag.

Originally Posted by M344587487

It is but not human-readable. The format preda is using is x.y-z-hash, might as well follow convention.

That did it. I was on the latest commit and either pulled before you added the tag or "git pull origin master" doesn't get the tag.

exact, only "git pull" gets the tag.

[preda]

Warning for ROCm users: refrain from upgrading to recently-released ROCm 2.3, there is a 5% perf degradation. https://github.com/RadeonOpenCompute/ROCm/issues/766