if then....

[pepi37]

my script

echo "STATUS OF GFN PROCESS" 
echo "ps -C GFN22 --no-headers | wc -l"  |      //read number of process with this name
read x 
if [ $x = 7 ]; then                                          //compare with 7
echo "WARNING SOME WORKER DONT WORK"
else
echo "ALL WORKERS WORKING"   
fi
echo `ps -C GFN22 --no-headers | wc -l`  |awk '{print "PERCENTAGE OF PROCESS " $1*100/7 " % "}'

But this doesnot work

if I echo "ps -C GFN22 --no-headers | wc -l" > x then x contain 7 : since 7 GPU run GFN22 process
But script doesnot compare , since I can change anything and still showing all worker is running.
I try $x and "$x" and some write Debian has own bash.....
What I do wrong?

[retina]

Using normal quotes with echo: echo "ps -C GFN22 --no-headers | wc -l"

Elide the read x and try this x=$(ps -C GFN22 --no-headers | wc -l)

[pepi37]

Originally Posted by retina

Using normal quotes with echo: echo "ps -C GFN22 --no-headers | wc -l"

Elide the read x and try this x=$(ps -C GFN22 --no-headers | wc -l)

If I use normal quotes then command give me incorrect result. ( both are same: in first I use " in last line I use ` )


x=$(ps -C GFN22 --no-headers | wc -l) doesnot work still wrong result.

[retina]

It seems weird to me that when x=7 you say some not working, but any other number means all working.

[slandrum]

Originally Posted by pepi37

if [ $x = 7 ]; then                                          //compare with 7
echo "WARNING SOME WORKER DONT WORK"
else
echo "ALL WORKERS WORKING"   
fi

So if X is 7, you are wanting to print that some workers are not working, but if x is NOT 7 then all the workers are? I think you have it flipped.

ETA: retina got in their response while I was staring at this.

[EdH]

Not sure, but don't forget = and == are different. You need == to compare.

[retina]

Originally Posted by EdH

Not sure, but don't forget = and == are different. You need == to compare.

For the [ is makes no difference AFAICT.

~  if [ 7 == 7 ] ; then echo y ; fi
y
~  if [ 6 == 7 ] ; then echo y ; fi
~  if [ 7 = 7 ] ; then echo y ; fi
y
~  if [ 6 = 7 ] ; then echo y ; fi
~

[EdH]

Hence, the "Not sure."

Another thought - what if you use "< 8" rather than "= 7" in your test?

[pepi37]

Originally Posted by slandrum

So if X is 7, you are wanting to print that some workers are not working, but if x is NOT 7 then all the workers are? I think you have it flipped.

ETA: retina got in their response while I was staring at this.

echo "STATUS GFN PROCESS"
x=$( echo `ps -C GFN22 --no-headers | wc -l` )
if [ x = 6 ]; then
echo "ALL WORKERS WORKING"
else
echo "ALL WORKERS NOT WORKING"
fi



I can change x = 6 or x = 7 and will get again wrong answer: so script doesnot compare number 7 ( as result) with if then statement. In this case x is compared to 6 and since it is 7 all workers not working is correct answer, But if I change to x = 7 then again got same answer: all workers is not working. So for that I know script doesnot compare well .

[retina]

Originally Posted by pepi37

...
if [ x = 6 ]; then ....

if [ $x = 6 ] ...

[pepi37]

Originally Posted by retina

if [ $x = 6 ] ...

I looks like I need big glasses!
Thanks Retina !