Trouble making msieve

[CRGreathouse]

I wasn't able to make msieve. Is there something I should be doing other than just "make {target} ECM=1"? I just downloaded the 1.41 source and did make (actually I changed the arch line in the makefile, but I get the same error either way):

gcc -D_FILE_OFFSET_BITS=64 -O3 -fomit-frame-pointer -march=k8 -DNDEBUG  -Wall -W -Wconversion -I. -Iinclude -Ignfs/poly -DHAVE_GMP_ECM -DHAVE_GMP -c -o common/smallfact/gmp_ecm.o common/smallfact/gmp_ecm.c
In file included from include/msieve.h:24,
                 from include/common.h:17,
                 from common/smallfact/gmp_ecm.c:21:
include/mp.h: In function ‘mp_cmp’:
include/mp.h:113: warning: conversion to ‘int32’ from ‘unsigned int’ may change the sign of the result
include/mp.h: In function ‘mp_mod_1_core’:
include/mp.h:216: warning: conversion to ‘int32’ from ‘uint32’ may change the sign of the result
include/mp.h: In function ‘mp_d2mp’:
include/mp.h:641: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
include/mp.h:643: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
include/mp.h:645: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
In file included from common/smallfact/gmp_ecm.c:34:
include/gmp_xface.h: In function ‘gmp2int64’:
include/gmp_xface.h:92: warning: conversion to ‘int64’ from ‘uint64’ may change the sign of the result
include/gmp_xface.h:95: warning: conversion to ‘int64’ from ‘uint64’ may change the sign of the result
common/smallfact/gmp_ecm.c: In function ‘postprocess’:
common/smallfact/gmp_ecm.c:117: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
common/smallfact/gmp_ecm.c:118: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
common/smallfact/gmp_ecm.c: In function ‘ecm_pp1_pm1’:
common/smallfact/gmp_ecm.c:261: error: incompatible type for argument 5 of ‘pm1’
common/smallfact/gmp_ecm.c:261: warning: passing argument 14 of ‘pm1’ makes pointer from integer without a cast
common/smallfact/gmp_ecm.c:261: warning: passing argument 16 of ‘pm1’ from incompatible pointer type
common/smallfact/gmp_ecm.c:261: error: too many arguments to function ‘pm1’
common/smallfact/gmp_ecm.c:281: error: incompatible type for argument 5 of ‘pp1’
common/smallfact/gmp_ecm.c:281: warning: passing argument 14 of ‘pp1’ makes pointer from integer without a cast
common/smallfact/gmp_ecm.c:281: warning: passing argument 16 of ‘pp1’ from incompatible pointer type
common/smallfact/gmp_ecm.c:281: error: too many arguments to function ‘pp1’
common/smallfact/gmp_ecm.c:312: error: incompatible type for argument 6 of ‘ecm’
common/smallfact/gmp_ecm.c:312: warning: passing argument 18 of ‘ecm’ from incompatible pointer type
common/smallfact/gmp_ecm.c:312: error: too many arguments to function ‘ecm’
make: *** [common/smallfact/gmp_ecm.o] Error 1

[henryzz]

Originally Posted by CRGreathouse

I wasn't able to make msieve. Is there something I should be doing other than just "make {target} ECM=1"? I just downloaded the 1.41 source and did make (actually I changed the arch line in the makefile, but I get the same error either way):

gcc -D_FILE_OFFSET_BITS=64 -O3 -fomit-frame-pointer -march=k8 -DNDEBUG  -Wall -W -Wconversion -I. -Iinclude -Ignfs/poly -DHAVE_GMP_ECM -DHAVE_GMP -c -o common/smallfact/gmp_ecm.o common/smallfact/gmp_ecm.c
In file included from include/msieve.h:24,
                 from include/common.h:17,
                 from common/smallfact/gmp_ecm.c:21:
include/mp.h: In function ‘mp_cmp’:
include/mp.h:113: warning: conversion to ‘int32’ from ‘unsigned int’ may change the sign of the result
include/mp.h: In function ‘mp_mod_1_core’:
include/mp.h:216: warning: conversion to ‘int32’ from ‘uint32’ may change the sign of the result
include/mp.h: In function ‘mp_d2mp’:
include/mp.h:641: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
include/mp.h:643: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
include/mp.h:645: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
In file included from common/smallfact/gmp_ecm.c:34:
include/gmp_xface.h: In function ‘gmp2int64’:
include/gmp_xface.h:92: warning: conversion to ‘int64’ from ‘uint64’ may change the sign of the result
include/gmp_xface.h:95: warning: conversion to ‘int64’ from ‘uint64’ may change the sign of the result
common/smallfact/gmp_ecm.c: In function ‘postprocess’:
common/smallfact/gmp_ecm.c:117: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
common/smallfact/gmp_ecm.c:118: warning: conversion to ‘uint32’ from ‘int’ may change the sign of the result
common/smallfact/gmp_ecm.c: In function ‘ecm_pp1_pm1’:
common/smallfact/gmp_ecm.c:261: error: incompatible type for argument 5 of ‘pm1’
common/smallfact/gmp_ecm.c:261: warning: passing argument 14 of ‘pm1’ makes pointer from integer without a cast
common/smallfact/gmp_ecm.c:261: warning: passing argument 16 of ‘pm1’ from incompatible pointer type
common/smallfact/gmp_ecm.c:261: error: too many arguments to function ‘pm1’
common/smallfact/gmp_ecm.c:281: error: incompatible type for argument 5 of ‘pp1’
common/smallfact/gmp_ecm.c:281: warning: passing argument 14 of ‘pp1’ makes pointer from integer without a cast
common/smallfact/gmp_ecm.c:281: warning: passing argument 16 of ‘pp1’ from incompatible pointer type
common/smallfact/gmp_ecm.c:281: error: too many arguments to function ‘pp1’
common/smallfact/gmp_ecm.c:312: error: incompatible type for argument 6 of ‘ecm’
common/smallfact/gmp_ecm.c:312: warning: passing argument 18 of ‘ecm’ from incompatible pointer type
common/smallfact/gmp_ecm.c:312: error: too many arguments to function ‘ecm’
make: *** [common/smallfact/gmp_ecm.o] Error 1

which version of gmp-ecm did you use?
has msieve been changed to cope with the new 6.2.2?

[akruppa]

I think no changes should be neccessary, the interface to GMP-ECM has not changed between 6.2.1 and 6.2.2. Charles, which version of GMP-ECM do you have installed?

Alex

[jasonp]

The code uses calls to pm1(), pp1() and ecm() which have an extra argument in the latest SVN revision (but not in the release of GMP-ECM 6.2.2). In fact, the windows demo binary is linked to 6.2.2

Brian Gladman already reported the trouble, perhaps I should switch to using the supported GMP-ECM interface.

[akruppa]

Ah, I see... Romain Cosset's hyper-ellipic curve code changed the interface. I forgot that.

IIRC, the original reason for not using the "official" GMP-ECM interface was that the code was not under LGPL but GPL by mistake, but that was fixed in the meantime.

Alex

[CRGreathouse]

Originally Posted by akruppa

Charles, which version of GMP-ECM do you have installed?

Whoops, that's it. I had an old version installed. When I made 6.2.2 and retried msieve it worked fine (though it threw up a whole lot of casting errors).